Skip to content

CI hardening: drop persisted checkout credential in lint workflow#35

Merged
stevebeattie merged 3 commits into
chainguard-dev:mainfrom
stevebeattie:security/psec-923-pre-commit-hooks
Jun 26, 2026
Merged

CI hardening: drop persisted checkout credential in lint workflow#35
stevebeattie merged 3 commits into
chainguard-dev:mainfrom
stevebeattie:security/psec-923-pre-commit-hooks

Conversation

@stevebeattie

Copy link
Copy Markdown
Member

Summary

Small GitHub Actions security-hardening changes to lint.yaml, surfaced by a
zizmor audit of .github/. No behavioral change to the lint job.

Changes

  • .github/workflows/lint.yaml — set persist-credentials: false on the
    actions/checkout step. The job only runs setup-python and pre-commit,
    with no git writes, so the checkout has no reason to leave the GITHUB_TOKEN
    in the local git config where later steps could read it. This closes the
    artipacked credential-persistence finding.

  • .github/workflows/lint.yaml — normalize the checkout pin's version
    comment from # ratchet:actions/checkout@v4.2.2 to # v4.2.2, matching the
    plain # vX.Y.Z convention used by every other pin in the repo. The SHA is
    unchanged (it is exactly v4.2.2); this only tidies the lone non-standard
    annotation.

  • .github/zizmor.yml (new) — disable the cosmetic pedantic-persona rule
    concurrency-limits, with the zizmor workflow's paths: triggers extended
    to include the new config so edits to it re-run the check.

Testing

  • zizmor (whole repo): no findings after the change.
  • actionlint: clean.
  • Patches apply cleanly on top of main; all workflows still parse.
  • Independently reviewed by a second pass: no blocking issues.

Refs: PSEC-923

Refs: PSEC-923
Generated-By: claude-guard chain b76b1bae11938b020aa6efb7c6301236
Skills-Applied: ref-version-mismatch
Skills-Sha: e807467ba50afb365a042ab4ad88b49c0ad4a4644ff06e0396a2116307be8ac3
Image-Sha: sha256:7263f9b592131d79316129974effb2efc6a19a2cfea7c2c4dd445664550901bb
Refs: PSEC-923
Generated-By: claude-guard chain b76b1bae11938b020aa6efb7c6301236
Skills-Applied: artipacked
Skills-Sha: e807467ba50afb365a042ab4ad88b49c0ad4a4644ff06e0396a2116307be8ac3
Image-Sha: sha256:7263f9b592131d79316129974effb2efc6a19a2cfea7c2c4dd445664550901bb
Refs: PSEC-923
Generated-By: claude-guard chain b76b1bae11938b020aa6efb7c6301236
Skills-Applied: zizmor-config
Skills-Sha: e807467ba50afb365a042ab4ad88b49c0ad4a4644ff06e0396a2116307be8ac3
Image-Sha: sha256:7263f9b592131d79316129974effb2efc6a19a2cfea7c2c4dd445664550901bb
@stevebeattie stevebeattie requested review from egibs and eslerm June 26, 2026 00:24
@stevebeattie stevebeattie merged commit 9e9472d into chainguard-dev:main Jun 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant