Skip to content

Fixes and refactor for appstreams promise type#133

Merged
nickanderson merged 1 commit intocfengine:masterfrom
nickanderson:CFE-3635/master
Apr 10, 2026
Merged

Fixes and refactor for appstreams promise type#133
nickanderson merged 1 commit intocfengine:masterfrom
nickanderson:CFE-3635/master

Conversation

@nickanderson
Copy link
Copy Markdown
Member

No description provided.

@olehermanse olehermanse self-requested a review April 3, 2026 23:46
Copy link
Copy Markdown
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future PRs, if possible, try to split up changes into multiple commits and add some context as to what you are fixing.

It would also be nice if you added references in the commit messages to support claims like:

DNF's module database can mark a profile as installed even if the RPM transaction failed (e.g. due to a stale cache error)

@nickanderson
Copy link
Copy Markdown
Member Author

For future PRs, if possible, try to split up changes into multiple commits and add some context as to what you are fixing.

Fair

It would also be nice if you added references in the commit messages to support claims like:

DNF's module database can mark a profile as installed even if the RPM transaction failed (e.g. due to a stale cache error)

You mean like cli output that showed the weird state on the system from my testing or you mean links to some other documentation?

@nickanderson nickanderson merged commit fecb785 into cfengine:master Apr 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants