Added container to compile/unittest with ASAN - #6336
Merged
Conversation
larsewi
reviewed
Aug 28, 2026
Ticket: CFE-3419 Changelog: None Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
SimonThalvorsen
force-pushed
the
CFE-3419
branch
from
August 28, 2026 10:49
3d2ad1b to
6975b91
Compare
larsewi
approved these changes
Aug 28, 2026
| local n_procs use_procs | ||
| n_procs="$(getconf _NPROCESSORS_ONLN)" | ||
| use_procs=$((n_procs/2)) | ||
| if [ "$use_procs" -lt "1" ]; then |
Contributor
There was a problem hiding this comment.
Suggested change
| if [ "$use_procs" -lt "1" ]; then | |
| if [ "$use_procs" -lt 1 ]; then |
larsewi
reviewed
Aug 28, 2026
Comment on lines
+22
to
+27
| failure=0 | ||
| if ! check_with_asan; then | ||
| echo "FAIL: ASAN compile/unit check failed"; | ||
| failure=1; | ||
| fi | ||
| exit $failure |
Contributor
There was a problem hiding this comment.
Suggested change
| failure=0 | |
| if ! check_with_asan; then | |
| echo "FAIL: ASAN compile/unit check failed"; | |
| failure=1; | |
| fi | |
| exit $failure | |
| if ! check_with_asan; then | |
| echo "FAIL: ASAN compile/unit check failed"; | |
| exit 1; | |
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CFE-3419
Changelog: None