style(log-viewer): one type scale and one mono family - #928
Open
lukecotter wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One type scale and one mono family for the whole webview, replacing hand-written pixel sizes and bare
monospaceliterals.Why
Text sizes were set per component, so the same kind of text read at a different size depending on where it sat, and none of it followed the reader's VS Code font size. Code-shaped text picked its family per file.
How
styles/tokens.css:--lana-text-lg→--vscode-bodyFontSize(13px)--lana-text-base→--vscode-bodyFontSize-small(12px)--lana-text-sm→--vscode-bodyFontSize-xSmall(11px)--lana-text-xs→ 0.84 × base (10px)--lana-text-caps+--lana-text-caps-trackingfor section headers--lana-font-mono→var(--vscode-editor-font-family, monospace)— carries the only non-VS-Code-host fallback. Applied to the table name columns, group rows, tooltips and code blocks.Notes
--vscode-editor-font-size, so a large editor font puts grid cells a step above the app base. Left as is — a separate decision.Testing
tsc -b --force,eslint,jest(1552 tests / 121 suites) and the production build all pass.