feat: group by caller namespace across data-table views#759
Merged
lcottercertinia merged 6 commits intoMay 12, 2026
Conversation
…or improved accessibility
Extend the caller-namespace grouping (added on DML/SOQL) to the Analysis and Bottom-Up views and align their toolbars. - Add `callerNamespace` to AggregatedRow, BottomUpRow, and MergedCalltreeRow so it's available as a hidden grouping field (no visible column). - Add "Caller Namespace" to the group-by dropdown on Analysis and Bottom-Up; route the label to the `callerNamespace` field. - Reorder both toolbars to Actions → Filters → Group for consistency. - Apply the Details filter on Bottom-Up too (previously skipped). - Extract `expandCollapseAll` (gated on `getTreeChildren().length` so it tolerates uninitialised rows under virtualisation) and `makeShowDetailsFilter` into shared utilities; consume them from CalltreeView and AnalysisView.
lcottercertinia
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
Adds a Group by Caller Namespace option across the Analysis, Bottom-Up, SOQL, and DML views, so users can see at a glance which package's code is responsible for activity in other namespaces (especially useful when SOQL/DML runs in
defaultbut was triggered by a managed package).Also aligns the Bottom-Up and Analysis toolbars to a consistent Actions → Filters → Group order, applies the Details filter on Bottom-Up (previously skipped), and fixes a Tabulator expand/collapse crash on Bottom-Up.
🛠️ Changes made
getCallerNamespace(event)utility (log-viewer/src/core/utility/CallerNamespace.ts) that returns the namespace of an event's direct parent (memoized).callerNamespacefield onAggregatedRow,BottomUpRow, andMergedCalltreeRowso it's available for grouping without taking up a visible column.callerNamespacefield.expandCollapseAllinto a shared util (features/call-tree/utils/ExpandCollapse.ts) that gates recursion onrow.getTreeChildren().length— tolerates uninitialised rows under Tabulator's virtualisation rather than crashing inDataTree.expandRow.makeShowDetailsFilterinto a shared util (features/call-tree/utils/DetailsFilter.ts).command:URI.🧩 Type of change (check all applicable)
🔗 Related Issues
resolves #604
✅ Tests added?
Added
CallerNamespace.test.tscovering strict-direct-parent semantics and memoisation. Existing Aggregation and call-tree tests cover the newcallerNamespacefield path. 846/846 pass.📚 Docs updated?
Anything else we need to know?
The Bottom-Up Expand/Collapse fix uses
getTreeChildren().length > 0as a guard rather than callingtreeExpandblindly. This is a workaround for an upstream Tabulator inconsistency:DataTree.expandRow/collapseRow/toggleRowaccessrow.modules.dataTree.childrenwithout guardingconfig, while the siblinggetTreeChildrendoes guard. Under virtualisation (Tabulator's default), off-screen rows never getrow-init, somodules.dataTreeis undefined andexpandRowthrows. Proper upstream fix would be lazy-initialisation inside those three methods. Tracked in ourtabulator_known_bugs.mdmemory note.