Skip to content

feat(prow): adding 1.36 jobs for testing#1172

Open
hjoshi123 wants to merge 1 commit intocert-manager:masterfrom
hjoshi123:feat/k8s-1-36-test-job
Open

feat(prow): adding 1.36 jobs for testing#1172
hjoshi123 wants to merge 1 commit intocert-manager:masterfrom
hjoshi123:feat/k8s-1-36-test-job

Conversation

@hjoshi123
Copy link
Copy Markdown
Contributor

@hjoshi123 hjoshi123 commented Apr 23, 2026

No description provided.

@hjoshi123
adding 1.36 jobs for testing
fd110ed 
Signed-off-by: hjoshi123 <mail@hjoshi.me>
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow Bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thatsmrtalbot for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 23, 2026
erikgb
erikgb reviewed Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@erikgb erikgb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm.

But I am pretty sure this will fail until we have kind images for K8s 1.36, ref. https://github.com/cert-manager/cert-manager/blob/59d77cbfb759f9c9e97599cf863572c0f6fb069c/make/kind_images.sh#L17-L21 🤔 Should we wait until a new kind release is available?

@hjoshi123
Copy link
Copy Markdown
Contributor Author

hjoshi123 commented Apr 23, 2026

Yes probably.. there may be no point to merge this until we have a release to test this in a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikgb erikgb erikgb left review comments

Assignees

No one assigned

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hjoshi123 @erikgb