fix: keep real name of spaces marked as favorite - #267
Open
arthurarabelo wants to merge 1 commit into
Open
arthurarabelo wants to merge 1 commit into
arthurarabelo wants to merge 1 commit into
Conversation
The basename of a space marked as favorite is its id, so the solution is to keep using the resource name in this case. buildResource preferred resource.basename, introduced in b1cdbb3 to fix the .0 removal. To also treat this case, the coercion is checked comparing the basename number and the name. If the coercion occurs, basename is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://its.cern.ch/jira/browse/CERNBOX-4407
The basename of a space marked as favorite is its own id, so the solution is to keep using the resource name in this case.
buildResource preferred resource.basename, introduced in b1cdbb3 to fix the .0 removal. To also treat this case, the coercion is checked comparing the basename number and the name. If the coercion occurs, basename is used.