Add Windows thread affinity support - #338
Conversation
|
Check-perf-impact results: (ae6918621b46271c2f10d6eb978fe95d) ❓ No new benchmark data submitted. ❓ |
PeterTh
left a comment
PeterTh
left a comment
There was a problem hiding this comment.
Instead of duplicating the win.cc / unix.cc, I think the win version could just be reduced to a include of the helper header plus a include of the unix.cc, with an explanation (of the windows helper introducing compat with the unix impl).
| #ifdef _WIN32 | ||
| #define SKIP_UNSUPPORTED() SKIP("Affinity is not supported on Windows"); | ||
| #define SKIP_UNSUPPORTED() // SKIP("Affinity is not supported on Windows"); | ||
| #else | ||
| #define SKIP_UNSUPPORTED() | ||
| #endif |
There was a problem hiding this comment.
This whole code block (and the invocation sites) can just be removed.
| @@ -0,0 +1,105 @@ | |||
| #pragma once | |||
|
|
|||
There was a problem hiding this comment.
This file should have a comment at the start explaining its purpose (i.e. implementing unix-like affinity using windows APIs).
maybe the name should also be something like affinity_win32_adapter?
2 participants
Thread pinning was previously a no-op on Windows:
thread_pinneronly emitted a warning ("Thread pinning is currently not supported on Windows.") and did not apply any affinity settings, regardless of configuration.This PR adds a real implementation by introducing a small pthread/
cpu_set_tcompatibility layer (platform_specific/affinity_win32.h/.cc). The layer maps the POSIX affinity APIs already used by Celerity (sched_getaffinity/sched_setaffinity,pthread_self,pthread_get/setaffinity_np,CPU_SET/CPU_ISSET/CPU_COUNT, etc.) to their Windows equivalents (GetActiveProcessorGroupCount,GROUP_AFFINITY,SetThreadGroupAffinity).With this compatibility layer in place,
affinity_win.ccno longer requires separate pinning logic and now closely mirrors the Linux implementation. It initializes and tears down the pinning plan in the same way and pins threads to sequential cores using the same approach.One limitation to note: Windows organizes logical processors into groups of up to 64 processors, and a single
GROUP_AFFINITYmask cannot span multiple groups. If a requested core set crosses a group boundary, the layer currently emits a warning and skips pinning instead of attempting cross-group affinity. This should not affect the common case of pinning a small number of sequential cores, but remains a limitation on systems with more than 64 logical processors.Added corresponding tests in
affinity_tests.cc.