Adapt tests for Windows compatibility - #337
Open
GagaLP wants to merge 1 commit into
Open
Conversation
|
Check-perf-impact results: (ae6918621b46271c2f10d6eb978fe95d) ❓ No new benchmark data submitted. ❓ |
PeterTh
requested changes
Aug 3, 2026
PeterTh
left a comment
PeterTh
left a comment
Contributor
There was a problem hiding this comment.
One small change request, looks good otherwise.
| namespace { | ||
| #ifdef _WIN32 // Windows' std::unordered_map sorts differently than other standard library implementations, which causes the printed graph to differ. Since the | ||
| // tests at the moment rely on exact string matching, we disable them on Windows until we have a better solution. | ||
| #define SKIP_UNSUPPORTED() \ |
Contributor
There was a problem hiding this comment.
This should be a bit more specific, maybe something like SKIP_WIN32_GRAPH_PRINT_UNSUPPORTED.
GagaLP
force-pushed
the
fix/windows-testing
branch
from
August 3, 2026 15:33
c77625b to
a38b899
Compare
Coverage Report for CI Build 30828102149Coverage increased (+0.02%) to 95.085%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to PR #336 and fixes several tests to improve Windows support.
The changes affect task, command, and instruction graph printing tests as well as
live_executorstarvation/active-time tests:std::unordered_map. Since MSVC's standard library uses a different iteration order, these tests fail on Windows even though graph construction is correct. The tests are disabled for now until a more robust graph comparison method is available.live_executorstarvation/active-time test tolerance is now platform-dependent, using 20ms on Windows (where the previous tolerance was too strict) and 10ms on other platforms, instead of increasing the tolerance globally.