fix: merge checkout events onto storefront distinct ids#37
Open
apps3000 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_posthog_distinct_idfrom Shopify checkout/cart attributes passed in from the storefront.Why
Tuftinglove's Hydrogen storefront writes the PostHog storefront
distinct_idinto the Shopify cart as_posthog_distinct_id. PixieHog previously used its own Web Pixel distinct id and later identified by email, so checkout events often landed on a separate PostHog person. Using the storefront id directly lets checkout events merge into the existing storefront person.Verification
npm run buildnpx eslint extensions/web-pixel/src/index.ts extensions/web-pixel/src/storefront-identity.tsnpx tsc --noEmit --pretty falseshows noextensions/web-pixelerrors; existing unrelated app settings type errors remain inapp/routes/app.web-pixel-settings/default-web-pixel-settings.ts.Notes
celadonworks/pixiehog-appwas not permitted for theapps3000account, so this PR is opened from theapps3000/pixiehog-appfork.