Fix - #1815
Merged
Merged
Conversation
RamilCDISC
approved these changes
Jul 30, 2026
RamilCDISC
left a comment
RamilCDISC
left a comment
Collaborator
There was a problem hiding this comment.
The PR resolves bug caused by wrong return statement, and less strict check of SUPP datasets. The two changes made in PR fixes the bugs. All unit and regression tests pass confirming proper integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1 (crash): In dataset_preprocessor.py, the SUPP-domain child-merge logic (_merge_standard_then_filter_idvar/_merge_idvar_only) returned child_records.class.from_records(results) instead of a plain pd.DataFrame, causing a PandasDatase to wrap another PandasDataset that crashed future function invocations due to the double wrap.
Bug 2 (wrong data): In rule_processor.py, resolving an operation's "SUPP--" domain wildcard always picked the first startswith("SUPP") dataset in the study rather than the one actually being validated, so validating SUPPLB could silently compute against SUPPDM's data instead.
Test against CORE-000712 (positive/01, SUPPLB/SUPPDM).