Skip to content

587 Core Rules 1689 Blocked Fix - #1814

Open
aniemes wants to merge 22 commits into
mainfrom
587_corerules_1689
Open

587 Core Rules 1689 Blocked Fix#1814
aniemes wants to merge 22 commits into
mainfrom
587_corerules_1689

Conversation

@aniemes

@aniemes aniemes commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Created

@aniemes

aniemes commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator Author

This will replace PR #1810 as it was created with the incorrect HEAD

@aniemes aniemes linked an issue Jul 30, 2026 that may be closed by this pull request
Comment thread cdisc_rules_engine/operations/regex_find_replace.py Outdated
Comment thread cdisc_rules_engine/operations/regex_find_replace.py
Comment thread resources/schema/rule/Operations.json

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated schema has not been merged with markdown descriptions. Please run the "Merge Schema with Markdown Descriptions" workflow to update the merged schema files.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated schema has not been merged with markdown descriptions. Please run the "Merge Schema with Markdown Descriptions" workflow to update the merged schema files.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated schema has not been merged with markdown descriptions. Please run the "Merge Schema with Markdown Descriptions" workflow to update the merged schema files.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated schema has not been merged with markdown descriptions. Please run the "Merge Schema with Markdown Descriptions" workflow to update the merged schema files.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated schema has not been merged with markdown descriptions. Please run the "Merge Schema with Markdown Descriptions" workflow to update the merged schema files.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated schema has not been merged with markdown descriptions. Please run the "Merge Schema with Markdown Descriptions" workflow to update the merged schema files.

@RamilCDISC RamilCDISC left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR adds regex_find_replace operation to unblock CORE_Rule 1689. The updated code was validated by:

  1. Review the PR for any unwanted code or comments.
  2. Review the PR is in accordance with AC.
  3. Review the PR for new implemented logic.
  4. Review the PR for repository code practices.
  5. Review the PR for already followed practice for addition of an operation.
  6. Review the PR for added tests.
  7. Ensure all unit and regression testing pass.
  8. Ensure new regression and unit test cover the AC.
  9. Ensure all relevant documentation is updated.
  10. Ensuring the schema is updated to include this new operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rule blocked: CORERULES-1689

2 participants