SYS-8273 catch more window cases, add python and python 3 cases#35
Merged
Conversation
…est with import sys and add error if not found
There was a problem hiding this comment.
Pull request overview
Updates the git hook shell wrappers to better detect Windows-like environments and to select an available Python interpreter before delegating to the corresponding *.py hook implementation.
Changes:
- Expand
$OSTYPEmatching to include additional Windows/MSYS variants and standardize log messages. - Prefer
python3when available, otherwise fall back topython, and fail fast with an error when no runnable Python is found. - Switch to array-based invocation (
"${PYTHON_EXECUTABLE[@]}") to keep command execution robust.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| main/pre-merge-commit | Updates OS detection and Python selection logic for the pre-merge hook wrapper. |
| main/pre-commit | Updates OS detection and Python selection logic for the pre-commit hook wrapper. |
| main/commit-msg | Updates OS detection and Python selection logic for the commit-msg hook wrapper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
layfield-ccdc
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.