Fix relative PRE_TEST discovery paths#3175
Open
NgoQuocViet2001 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #3175 +/- ##
==========================================
+ Coverage 91.09% 91.12% +0.03%
==========================================
Files 204 204
Lines 8922 8922
==========================================
+ Hits 8127 8130 +3
+ Misses 795 792 -3 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an opt-in
USE_RELATIVE_PATHSmode tocatch_discover_testsforDISCOVERY_MODE PRE_TEST.When enabled, the generated CTest include resolves the test executable, discovery script, working directory, and discovery cache relative to its own relocated build-tree location. This keeps the existing behavior unchanged by default, supports single- and multi-config generators, and requires CMake 3.24 for the path generator expressions. The option and version requirement are documented.
The regression relocates the build tree before first discovery, uses a generator-expression
WORKING_DIRECTORY, verifies the discovered names, runs the actual tests, and cleans the generated discovery cache.GitHub Issues
Closes #3051
Testing
git diff --checkpassedAI assistance
Codex (GPT-5, autonomous) implemented and iteratively validated the change on behalf of @NgoQuocViet2001. The operator requested the contribution but did not manually author or line-by-line review the patch.