Fix: kapp-controller silently drops errors when pushing CA certs/proxy settings to its sidecarexec container - #1850
Open
himsngh wants to merge 1 commit into
Conversation
Reconcile() was swallowing errors from ApplyCACerts/ApplyProxy, which are RPC calls to the sidecarexec container. If that container's socket wasn't listening yet (a real container-start race, no ordering guarantee within the Pod), the failure was logged and discarded, so CA certs/proxy could go permanently unapplied for the Pod's lifetime with no retry. Now Reconcile() returns the error so controller-runtime requeues watch- triggered reconciles with backoff, and the one-shot startup reconcile in run.go retries with a bounded backoff instead of silently continuing. Signed-off-by: Himanshu Singh <himansh.singh3@gmail.com>
himsngh
force-pushed
the
fix/config-reconciler-swallowed-osconfig-errors
branch
from
August 25, 2026 12:48
93a4254 to
2d1d6a9
Compare
himsngh
changed the title
aroradaman
approved these changes
Aug 27, 2026
aroradaman
left a comment
aroradaman
left a comment
Member
There was a problem hiding this comment.
This is not a breaking change, we just wait and retry when rpc call fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Propagate config reconciler errors so sidecar-not-ready races self-heal
Reconcile() was swallowing errors from ApplyCACerts/ApplyProxy, which are RPC calls to the sidecarexec container. If that container's socket wasn't listening yet (a real container-start race, no ordering guarantee within the Pod), the failure was logged and discarded, so CA certs/proxy could go permanently unapplied for the Pod's lifetime with no retry.
Now Reconcile() returns the error so controller-runtime requeues watch- triggered reconciles with backoff, and the one-shot startup reconcile in run.go retries with a bounded backoff instead of silently continuing.
Which issue(s) this PR fixes:
Fixes #1849
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: