Add missing eslint dependencies - #5851
Open
backspace wants to merge 1 commit into
Open
Conversation
realm-server and software-factory run eslint but depend on it only implicitly,
finding a binary hoisted from elsewhere in the workspace. Which major they lint
with is therefore a property of install ordering rather than of the package, and
two majors are present: most of the repo is on 8 while boxel-ui and
eslint-plugin-boxel are on flat config with 9.
That resolution is easy to disturb. Bumping either `@typescript-eslint` or
`ember-eslint-parser` changes how `@typescript-eslint/parser`'s `*` peer picks
an eslint, and both bumps independently flip these two packages to 9, where
they fail outright demanding flat config:
ESLint couldn't find an eslint.config.(js|mjs|cjs) file.
Depending on eslint explicitly makes each package lint with the version it
declares. No behaviour change here — both already resolve 8.57.1 on main, so
this only holds that still while the dependency graph moves around it.
Nine more packages lint without declaring eslint and carry the same exposure;
they are left alone because nothing has disturbed them yet, and the durable fix
is one eslint major across the repo rather than a declaration per package.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
realm-serverandsoftware-factoryuse it but didn’t declare it.Claude explanation
realm-server and software-factory run eslint but depend on it only implicitly, finding a binary hoisted from elsewhere in the workspace. Which major they lint with is therefore a property of install ordering rather than of the package, and two majors are present: most of the repo is on 8 while boxel-ui and eslint-plugin-boxel are on flat config with 9.That resolution is easy to disturb. Bumping either
@typescript-eslintorember-eslint-parserchanges how@typescript-eslint/parser's*peer picks an eslint, and both bumps independently flip these two packages to 9, where they fail outright demanding flat config:Depending on eslint explicitly makes each package lint with the version it declares. No behaviour change here — both already resolve 8.57.1 on main, so this only holds that still while the dependency graph moves around it.
Nine more packages lint without declaring eslint and carry the same exposure; they are left alone because nothing has disturbed them yet, and the durable fix is one eslint major across the repo rather than a declaration per package.