Update ember-eslint-parser and eslint-plugin-ember - #5848
Draft
backspace wants to merge 2 commits into
Draft
Conversation
realm-server and software-factory run eslint but depend on it only implicitly,
finding a binary hoisted from elsewhere in the workspace. Which major they lint
with is therefore a property of install ordering rather than of the package, and
two majors are present: most of the repo is on 8 while boxel-ui and
eslint-plugin-boxel are on flat config with 9.
That resolution is easy to disturb. Bumping either `@typescript-eslint` or
`ember-eslint-parser` changes how `@typescript-eslint/parser`'s `*` peer picks
an eslint, and both bumps independently flip these two packages to 9, where
they fail outright demanding flat config:
ESLint couldn't find an eslint.config.(js|mjs|cjs) file.
Depending on eslint explicitly makes each package lint with the version it
declares. No behaviour change here — both already resolve 8.57.1 on main, so
this only holds that still while the dependency graph moves around it.
Nine more packages lint without declaring eslint and carry the same exposure;
they are left alone because nothing has disturbed them yet, and the durable fix
is one eslint major across the repo rather than a declaration per package.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`ember-eslint-parser` 0.13.0 to 0.14.6, and `eslint-plugin-ember` 13.3.2 to 13.5.0. The two move together: 13.3.2 depends on the 0.13 line, so bumping only the parser leaves two copies in the tree, and the parser's own duplicate-version guard then fails every `.gts` file. 13.5.0 depends on `^0.14.2`, so the tree collapses to one parser again. The local patch applies to 0.14.6 unchanged. Beyond keeping current, 0.14.6 fixes how `.gts` files enter a TypeScript program. On 0.13.0, linting host with `parserOptions.project` left 974 files reporting that the tsconfig does not include them, and which files got types depended on how the program happened to be built. On 0.14.6 that is zero, and the run is faster — 49s against 337s. Depends on eslint being declared in realm-server and software-factory: this bump changes how `@typescript-eslint/parser`'s `*` peer resolves an eslint, and without that declaration both packages pick up eslint 9 and fail demanding flat config. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
backspace
force-pushed
the
bump-ember-eslint-parser
branch
from
August 21, 2026 17:42
6f7ca2a to
0a14cf8
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a step to make #5847 more useful.
Claude explanation
`ember-eslint-parser` 0.13.0 to 0.14.6, and `eslint-plugin-ember` 13.3.2 to 13.5.0. The two move together: 13.3.2 depends on the 0.13 line, so bumping only the parser leaves two copies in the tree, and the parser's own duplicate-version guard then fails every `.gts` file. 13.5.0 depends on `^0.14.2`, so the tree collapses to one parser again. The local patch applies to 0.14.6 unchanged.Beyond keeping current, 0.14.6 fixes how
.gtsfiles enter a TypeScript program. On 0.13.0, linting host withparserOptions.projectleft 974 files reporting that the tsconfig does not include them, and which files got types depended on how the program happened to be built. On 0.14.6 that is zero, and the run is faster — 49s against 337s.Declare eslint in realm-server and software-factory, which run it but relied on finding a binary hoisted from elsewhere. That resolution is what the bump disturbed: both picked up eslint 9 and failed demanding flat config, while staying on 8 everywhere else. Depending on it explicitly makes the version each package lints with a property of that package rather than of install ordering.