Honor symbol defaults for string command keys - #574
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use a supplied Symbol default when the command is looked up by its String spelling.
Reproduction and verification
CommandMap.new(rake: "/fixture/rake")["rake"] returns nil on baseline, despite normalized storage and the matching :rake default. Candidate returns the configured path. Explicit String-only defaults and default-proc inputs remain supported.
28e04dc73de911374a23c4fc3fd5ef34012dcd63; installed release is 1.25.1 (e35241b7a3acdf3df4d70442b4a2e69bbcfff155).Breaking changes / compatibility / limitations
No intended change for normal Symbol keys. If both spellings have conflicting explicit defaults, the Symbol entry takes priority, consistent with normalized command keys. Prefix/command combination behavior in #311 is unchanged.
No production access, real SSH sessions, deployment or concurrency increase.