Skip to content

Improvements for sample app#121

Open
lisajulia wants to merge 1 commit into
mainfrom
enhance/sample-app
Open

Improvements for sample app#121
lisajulia wants to merge 1 commit into
mainfrom
enhance/sample-app

Conversation

@lisajulia

Copy link
Copy Markdown
Contributor
  • extract supplier correctly
  • turn off recommendations for status field

@lisajulia
lisajulia requested a review from a team as a code owner July 17, 2026 07:05
@hyperspace-pr-bot

Copy link
Copy Markdown
Contributor

Summary

The following content is AI-generated and provides a summary of the pull request:


Sample App: Supplier Extraction & Status Recommendation Improvements

Bug Fix / New Feature

🛠️ Improved the bookshop sample app with two key enhancements: correct supplier matching from extracted invoice data and disabling UI recommendations for the status field.

Changes

  • fiori-service.cds: Added field title annotations (invoiceNumber, supplier, status) to SupplierInvoices for proper i18n label resolution in the UI.
  • schema.cds: Annotated SupplierInvoices.status with @UI.RecommendationState: 0 to turn off AI-driven recommendations for that field.
  • sap.capire.bookshop-Suppliers.csv: Added a new supplier entry (Studio Salford) for test data coverage.
  • pom.xml: Bumped cds-feature-sap-document-ai dependency version from 0.0.1-alpha to 0.0.2-alpha.
  • DocumentExtractionResultHandler.java:
    • Added imports for Suppliers, Suppliers_, Select, Optional, and Locale.
    • Extracts senderName from the DIE header fields and attempts to match it case-insensitively against existing Suppliers records via the new findSupplierByName method.
    • On a successful match, sets the supplierId on the invoice update; logs a warning if no match is found.
    • Updated log message to include the extracted sender name.
    • Updated Javadoc to reflect the supplier matching addition.

  • 🔄 Regenerate and Update Summary
  • ✏️ Insert as PR Description (deletes this comment)
  • 🗑️ Delete comment
PR Bot Information

Version: 1.28.0

  • File Content Strategy: Full file content
  • Output Template: Default Template
  • LLM: anthropic--claude-4.6-sonnet
  • Summary Prompt: Default Prompt
  • Event Trigger: pull_request.opened
  • Correlation ID: dd0f0370-81ad-11f1-9a3d-6a352c785d60

@hyperspace-pr-bot hyperspace-pr-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR introduces four issues worth addressing: an invalid email in the CSV seed data, a full-table-scan supplier lookup that should push filtering to the database, redundant @title annotations that duplicate existing inline labels, and a @UI.RecommendationState: 0 annotation that doesn't actually disable recommendations as the PR description claims.

PR Bot Information

Version: 1.28.0

  • LLM: anthropic--claude-4.6-sonnet
  • Correlation ID: dd0f0370-81ad-11f1-9a3d-6a352c785d60
  • File Content Strategy: Full file content
  • Event Trigger: pull_request.opened

Comment thread samples/bookshop/db/data/sap.capire.bookshop-Suppliers.csv Outdated
Comment thread samples/bookshop/app/supplier-invoices/fiori-service.cds
Comment thread samples/bookshop/db/schema.cds
- extract supplier correctly
- turn off recommendations for status field
@lisajulia
lisajulia force-pushed the enhance/sample-app branch from 8545fa9 to 5ef34e6 Compare July 20, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant