Add Accept header to curl commands in traffic docs - #1264
Conversation
|
@tomastauber-da did the debug on variable validation on the current changes, it seems to fail in MDX Page currently being in the commit with the changes. Basically, the committed synchronizer-traffic.mdx no longer matches what the generator produces. Could you please update the forked branch based on current content on Below is the specific error debug log block from the failed job outta the above check. |
5528048 to
5c8a36b
Compare
|
@Jatinp26 it should be fixed now |
6c2b477 to
aa00029
Compare
ported from canton-network/splice#4298 Signed-off-by: Tomas Tauber <tomas.tauber@digitalasset.com>
aa00029 to
5db59bc
Compare
|
@martinflorian-da since you were reviewing this originally, would you mind reviewing here please? |
|
Sure! @tomastauber-da I validated that the curl works both with and without your changes. I assume you're opening this because it didn't work for you without the extra Would be curious to understand this a bit better before approving. Specifically, how is it that I tested against https://scan.sv-1.dev.global.canton.network.sync.global/api/scan/v0/amulet-rules using two different |
|
@martinflorian-da previously, it didn't work without the header, but I haven't verified it in the recent versions |
That doesn't sound to me like confirmation enough that the problem exist to warrant merging a fix for it? As a frequent user of long |
|
@tomastauber-da I would also be curious to know the affected version of |
|
@martinflorian-da I tried with curl 8.7.1, and it works without the explicit Accept header. So I think this can be closed |
ported from canton-network/splice#4298