pdo: handle none cob_id correctly in __repr__#640
Open
stoicfeats wants to merge 1 commit intocanopen-python:masterfrom
Open
pdo: handle none cob_id correctly in __repr__#640stoicfeats wants to merge 1 commit intocanopen-python:masterfrom
stoicfeats wants to merge 1 commit intocanopen-python:masterfrom
Conversation
Author
|
@acolomb please have a look into this, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fxes a crash when calling repr() on a pdomap that doesn't have a cob_id assigned yet.
before this, working in an interactive session would throw a typeerror if we evaluated uninitialized maps like node.rpdo[1].
the string formatter was trying to apply : X hex-formatting to a nonetype value.
this adds a quick inline fallback so it prints "unassigned" instead of throwing error on the console.