refactor(http): remove deprecated remote_ip_header fallback

.changeset/remove-deprecated-remote-ip-header.md

@@ -0,0 +1,5 @@
+---
+"nostream": minor
+---
+
+refactor(http): remove deprecated network.remote_ip_header fallback and rely on network.remoteIpHeader

src/utils/http.ts

@@ -27,16 +27,21 @@ const isTrustedProxy = (ipAddress: string, settings: Settings): boolean => {
   })
 }
 
-export const getRemoteAddress = (request: IncomingMessage, settings: Settings): string => {
-  let header: string | undefined
-  // TODO: Remove deprecation warning
-  if ('network' in settings && 'remote_ip_header' in settings.network) {
-    logger.warn(`WARNING: Setting network.remote_ip_header is deprecated and will be removed in a future version.
-        Use network.remoteIpHeader instead.`)
-    header = settings.network['remote_ip_header'] as string
-  } else {
-    header = settings.network.remoteIpHeader as string
+const warnIfDeprecatedRemoteIpHeaderIsConfigured = (settings: Settings): void => {
+  const networkSettings = settings.network as Record<string, unknown> | undefined
+  const deprecatedHeader = networkSettings?.remote_ip_header
+
+  if (typeof deprecatedHeader === 'string' && deprecatedHeader.trim() !== '') {
+    logger.warn(
+      'WARNING: network.remote_ip_header is deprecated and no longer used. Rename it to network.remoteIpHeader to restore forwarded header handling.',
+    )
   }
+}
+
+export const getRemoteAddress = (request: IncomingMessage, settings: Settings): string => {
+  warnIfDeprecatedRemoteIpHeaderIsConfigured(settings)
+
+  const header = settings.network?.remoteIpHeader as string
 
   const trustedProxies = settings.network?.trustedProxies
   if (header && (!Array.isArray(trustedProxies) || trustedProxies.length === 0)) {

test/unit/utils/http.spec.ts

@@ -21,16 +21,16 @@ describe('getRemoteAddress', () => {
     } as any
   })
 
-  it('returns address using network.remote_ip_address when set', () => {
+  it('returns address using network.remoteIpHeader when set', () => {
     expect(
       getRemoteAddress(
         request,
-        { network: { 'remote_ip_header': header, trustedProxies: [socketAddress] } } as any,
+        { network: { remoteIpHeader: header, trustedProxies: [socketAddress] } } as any,
       )
     ).to.equal(address)
   })
 
-  it('returns address using network.remoteIpAddress when set', () => {
+  it('returns address using network.remoteIpHeader when set (duplicate shape)', () => {
     expect(
       getRemoteAddress(
         request,