refactor: simplify EventRepository query/purge complexity#625
Open
Ferryx349 wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: b9fc056 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Signed-off-by: ABHAY PANDEY <pandeyabhay967@gmail.com>
Collaborator
Author
|
resolved conflicts |
There was a problem hiding this comment.
Pull request overview
This PR refactors EventRepository to reduce method complexity while preserving existing SQL/query behavior, focusing on subscription filter construction and retention purge flow (Issue #46).
Changes:
- Refactors
applyFilterConditionsinto focused helpers for hex criteria grouping and generic tag criteria handling. - Refactors
deleteExpiredAndRetainedinto clearer steps (candidate selection, whitelist handling, purge count mapping) and introduces small constants for retention math/batch size. - Adds/extends unit tests to cover retention purge query construction and purge count mapping.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/repositories/event-repository.ts |
Splits complex filter and retention purge logic into smaller private helpers while keeping the generated SQL equivalent. |
test/unit/repositories/event-repository.spec.ts |
Adds tests for retention-disabled behavior, purge query SQL construction, and purge result counting logic. |
.changeset/vast-signs-melt.md |
Adds a patch changeset documenting the EventRepository refactor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies EventRepository by breaking down high-complexity logic in filter construction and retention purge flow.
It refactors applyFilterConditions into smaller helpers for hex and generic tag criteria handling, while preserving SQL behavior.
It also refactors deleteExpiredAndRetained into clearer steps (candidate selection, whitelist handling, purge count mapping).
Related Issue
Fixes- #46
Types of changes
Checklist: