fix: propagate working-directory input to all composite action steps#25
Merged
thymikee merged 1 commit intocallstackincubator:mainfrom Apr 13, 2026
Merged
Conversation
Several steps that run `npx rock remote-cache` or touch `.rock/cache` were missing `working-directory`, causing `rock.config not found` errors when the app is in a subdirectory. Closes callstackincubator#24
jbroma
added a commit
to jbroma/module-federation-core
that referenced
this pull request
Apr 13, 2026
…irectory fix Remove local action forks and reference upstream PRs: - callstackincubator/android#25 - callstackincubator/ios#27
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
working-directoryinput is accepted by the action but was not propagated to 10 out of ~20 composite steps. Any step that runsnpx rock remote-cache ...or touches.rock/cachewith a relative path would fail withrock.config not foundwhen the consuming repo's app lives in a subdirectory (i.e.working-directory!=.).Steps fixed (added
working-directory: ${{ inputs.working-directory }}):Steps that were already correct (had
working-directoryor don't need it) were left untouched.Closes #24