Skip to content

fix: resolve RN 0.85 web warnings and upgrade Expo SDK 56#4958

Merged
satya164 merged 2 commits into
callstack:mainfrom
azizbecha:@azizbecha/fix/rn-upgrade-warnings
May 26, 2026
Merged

fix: resolve RN 0.85 web warnings and upgrade Expo SDK 56#4958
satya164 merged 2 commits into
callstack:mainfrom
azizbecha:@azizbecha/fix/rn-upgrade-warnings

Conversation

@azizbecha
Copy link
Copy Markdown
Collaborator

Summary

  • fix deprecated web shadow and Image style warnings introduced with React Native 0.85
  • move affected Image resizeMode and tintColor usage to props
  • upgrade the example app from Expo SDK 56 preview to stable SDK 56 and align related packages

Testing

  • yarn typescript
  • yarn jest src/components/tests/Icon.test.tsx src/components/tests/Surface.test.tsx src/components/tests/Appbar/Appbar.test.tsx -u --runInBand
  • npx expo-doctor
  • repo pre-commit hook (lint, typescript, full test suite)

@azizbecha azizbecha changed the title Fix RN 0.85 web warnings and upgrade Expo SDK 56 fix: resolve RN 0.85 web warnings and upgrade Expo SDK 56 May 21, 2026
@azizbecha azizbecha requested a review from satya164 May 21, 2026 00:05
@callstack-bot
Copy link
Copy Markdown

callstack-bot commented May 21, 2026

Hey @azizbecha, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@azizbecha azizbecha requested a review from adrcotfas May 21, 2026 22:53
Comment thread example/src/Examples/BottomNavigationBarExample.tsx Outdated
Comment thread src/components/__tests__/Appbar/Appbar.test.tsx Outdated
Comment thread src/components/__tests__/Icon.test.tsx Outdated
Comment thread src/components/__tests__/Surface.test.tsx Outdated
Comment thread src/theme/tokens/sys/elevation.ts Outdated
Comment thread src/theme/tokens/sys/elevation.ts Outdated
- drop tests that asserted implementation details (Appbar/Icon/Surface)
- throw on a non-string shadow color on web instead of defaulting to black
- compute the web shadow color once and reuse it across the interpolation
- keep tintColor in style since only resizeMode/shadow* trigger warnings
@azizbecha azizbecha requested a review from satya164 May 25, 2026 17:54
Copy link
Copy Markdown
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@satya164 satya164 merged commit 3381515 into callstack:main May 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants