fix: call copyStrippedSoLibs once after the loop to avoid redundant SO file copying#353
Merged
Conversation
hurali97
approved these changes
May 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts JNI .so handling so copyStrippedSoLibs runs once per variant (instead of once per AAR), reducing redundant work when useStrippedSoFiles is enabled.
Changes:
- Move
copyStrippedSoLibs(variant, existingJNILibs)to execute once after the AAR loop. - Keep the non-stripped path behavior scoped to
!useStrippedSoFiles. - Add a changeset documenting the fix as a patch for
brownfield.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/processors/JNILibsProcessor.kt | Executes stripped .so copying once after iterating AARs to avoid redundant copying. |
| .changeset/grumpy-jars-see.md | Documents the behavioral/performance fix as a patch release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| } | ||
| } | ||
| if (projectExt.useStrippedSoFiles) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimize SO stripping by calling
copyStrippedSoLibsonce after the loop.