Skip to content

fix(ios): gate index>=4 appear-select on >5-tab overflow #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidecallegaro wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ios): gate index>=4 appear-select on >5-tab overflow #526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/react-native-bottom-tabs/ios/TabAppearModifier.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,12 @@ struct TabAppearModifier: ViewModifier {
#endif

#if os(iOS)
if context.index >= 4, context.props.selectedPage != context.tabData.key {
// Sync selection for tabs nested under the system "More" tab, which
// only exists when there are more than 5 visible tabs. Without the
// count guard the 5th tab (index 4) of a non-overflowing bar would
// force-select itself whenever its scene re-appears (e.g. when the tab
// bar is re-shown after `.hideTabBar`), hijacking the selection.
if context.props.filteredItems.count > 5, context.index >= 4, context.props.selectedPage != context.tabData.key {
context.onSelect(context.tabData.key)
}
#endif
Expand Down