fix: retry iOS runner prepare launch#692
Merged
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
b7c24b4 to
326c749
Compare
|
326c749 to
bccfda3
Compare
bccfda3 to
a839a7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retry
prepare ios-runnerhealth-check failures by invalidating the stuck runner session and launching a fresh one once, without forcing an.xctestrunrebuild.Keep the bad cached runner artifact recovery path separate and limited to the first prepare attempt: cached artifacts still get marked bad and rebuilt only when the initial restored artifact itself is suspect.
Handle review hardening: the retry loop is split below fallow complexity limits, cancellation is re-checked before relaunch, terminal retry invalidation is best-effort so it does not mask the original health error, and tests cover non-retryable startup failures plus attempt-two no-rebuild behavior.
Document the CI contract in command docs and CLI help: run
prepare ios-runnerafter boot/install and before replay/test, use exact runner cache keys, and avoid broad restore-key fallbacks.Validation
pnpm exec vitest run src/platforms/ios/__tests__/runner-command-retry.test.tspnpm exec vitest run src/__tests__/cli-help.test.tspnpm exec vitest run src/platforms/ios/__tests__/runner-command-retry.test.ts src/__tests__/cli-help.test.tspnpm check:fallowpnpm check:quickpnpm buildpnpm pack --pack-destination /tmp/tmp/agent-device-0.16.13.tgzin React Navigation and ranprepare ios-runneragainst iPhone 17 Pro successfully