Skip to content

fix: declare frameworkTier on the hover descriptor - #1817

Merged
thymikee merged 1 commit into
mainfrom
fix/hover-framework-tier
Aug 18, 2026
Merged

fix: declare frameworkTier on the hover descriptor#1817
thymikee merged 1 commit into
mainfrom
fix/hover-framework-tier

Conversation

@thymikee

Copy link
Copy Markdown
Member

Summary

main's Coverage job is red at 142d156: #1786 added the public hover command without a frameworkTier, and #1804 (merged after) added the parity rule that every public descriptor declares one. Neither PR's own CI saw the combination. Every open PR's Coverage lane now fails on parity.test.ts > frameworkTier is declared iff a command is public.

hover is web-only pointer state, not part of the curated perceive/act loop, so it lands in 'extended' (the parity test's pinned 'core' set is unchanged).

Validation

Red on main (revert of this one-liner): AssertionError: hover declares frameworkTier iff it is a public command — 1 failed | 14 passed. Green with it: parity + ai-sdk suites pass; pnpm check:affected --run green (426 files / 3641 tests). One file touched.

@github-actions

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 2.27 MB 2.27 MB +25 B
JS gzip 747.7 kB 747.7 kB +1 B
npm tarball 869.4 kB 869.4 kB +12 B
npm unpacked 3.03 MB 3.03 MB +25 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 27.4 ms 27.4 ms -0.1 ms
CLI --help 67.6 ms 65.5 ms -2.1 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/sdk-batch-runner.js +25 B +1 B

@thymikee

Copy link
Copy Markdown
Member Author

Clean review at 5fe3492: hover is public and correctly declares frameworkTier: 'extended' at the descriptor source of truth, restoring the parity invariant without changing routing or runtime behavior. The revert-red proof is meaningful, exact-head CI and all platform smokes pass, and device evidence does not apply to this metadata-only repair. Ready-for-human.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Aug 18, 2026
@thymikee
thymikee merged commit 4c5f693 into main Aug 18, 2026
28 checks passed
@thymikee
thymikee deleted the fix/hover-framework-tier branch August 18, 2026 11:53
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-18 11:54 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant