fix: declare frameworkTier on the hover descriptor - #1817
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
Member
Author
|
Clean review at 5fe3492: |
|
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main's Coverage job is red at 142d156: #1786 added the public
hovercommand without aframeworkTier, and #1804 (merged after) added the parity rule that every public descriptor declares one. Neither PR's own CI saw the combination. Every open PR's Coverage lane now fails onparity.test.ts > frameworkTier is declared iff a command is public.hoveris web-only pointer state, not part of the curated perceive/act loop, so it lands in'extended'(the parity test's pinned'core'set is unchanged).Validation
Red on main (revert of this one-liner):
AssertionError: hover declares frameworkTier iff it is a public command — 1 failed | 14 passed. Green with it: parity + ai-sdk suites pass;pnpm check:affected --rungreen (426 files / 3641 tests). One file touched.