Fix failing "Build Assets" GitHub Actions job#362
Open
jbrooksuk wants to merge 2 commits into
Open
Conversation
Speed up the test workflow: 1. Remove Xdebug coverage. `composer test` ran `pest --coverage` under Xdebug in every matrix job, but nothing consumed the report (no upload, no `--min` threshold). Drop `--coverage` from the test:unit script and set `coverage: none` in setup-php so Xdebug isn't loaded at all — it's the single largest slowdown in the suite. 2. Build front-end assets once. The compiled assets are identical across every test job, so build them in a dedicated `build-assets` job and share them via an artifact, instead of running `npm ci && npm run build` in all of them. Also cache the Composer download directory per php/stability so `composer update` doesn't re-download packages. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot
AI
changed the title
ci: speed up the test workflow (drop coverage, build assets once)
Fix failing "Build Assets" GitHub Actions job
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build-assetsjob inrun-tests.ymlwas failing because the CSS files reference Filament vendor assets (vendor/filament/support/resources/css/index.cssandvendor/filament/filament/resources/css/theme.css) that only exist after Composer dependencies are installed. The job was runningnpm run buildwithout first installing PHP dependencies, causing Vite to fail when it couldn't resolve those imports.Root Cause
resources/css/cachet.cssandresources/css/dashboard/theme.cssboth import CSS files from thevendor/directory. Thebuild-assetsjob did not include a PHP/Composer setup step, so the vendor directory was empty at build time.Fix
Added PHP setup and Composer dependency installation steps to the
build-assetsjob in.github/workflows/run-tests.yml, mirroring what thecompile-assets.ymlworkflow already does correctly.