Correct the stale next/font hashed-family-name comments - #1141
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
blove
enabled auto-merge (squash)
September 23, 2026 19:23
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
The Inter comment in layout.tsx and the FONTS note in ui.css both said
next/font registers families under a hashed name. That was true of older
next/font; next/font 16 registers the real name — the built CSS emits
`@font-face{font-family:Inter}` and `--font-diagram:"Inter","Inter Fallback"`.
#1139's italic split depends on exactly that.
The conclusions still hold, so behaviour is unchanged: theme.css's
`Inter, system-ui` stack only names the family, and the font file exists only
because next/font loads it. Remove the loader and diagrams still fall back to
system-ui. Only the stated mechanism was wrong.
blove
force-pushed
the
blove/next-font-family-comments
branch
from
September 23, 2026 19:36
b512765 to
8fa1969
Compare
Contributor
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only. Two comments said
next/fontregisters font families under a hashed name:apps/website/src/app/layout.tsxapps/website/src/styles/ui.cssThat was true of older
next/font(names like__Inter_aaf875), butnext/font16 registers the real family name. The current build emits@font-face{font-family:Inter;…}and--font-diagram:"Inter","Inter Fallback". #1139's Archivo italic split depends on exactly this: both instances registerArchivoand the browser merges them.The conclusions still hold, so nothing changes behaviourally.
theme.css'sInter, system-uistack only names the family; the font file exists only becausenext/fontloads it. Remove the loader and diagrams still fall back tosystem-ui. Only the stated reasoning was wrong, and it was the wrong reasoning to leave next to code that now relies on the opposite fact.Verification
nx test website,nx lint websitenx e2e website --grep "homepage architecture|homepage bundle"— 7 passed (architecture measures diagram text against Inter's metrics; bundle includes the italic-merge guard)🤖 Generated with Claude Code