Skip to content

Honor cancellation for LangGraph state writes - #1138

Merged
blove merged 3 commits into
mainfrom
codex/state-write-cancellation
Sep 23, 2026
Merged

blove merged 3 commits into
mainfrom
codex/state-write-cancellation

Conversation

@blove

@blove blove commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

FetchStreamTransport.updateState accepted an abort signal but never passed it to the LangGraph SDK. Pre-aborted writes still reached the server, and cancelling an in-flight write left its HTTP response open.

Forward the existing signal alongside values/asNode. Six real-SDK tests against a local HTTP server cover pre-abort, in-flight cancellation/connection closure, and unchanged successful request bodies through normal and protected transports. Cancellation reporting remains suppressed. Four cancellation cases fail before the fix; all six pass after it.

Validation: all 594 runtime tests, runtime/public type checks, LangGraph lint, the legacy transport test target, inventory and source boundaries pass. The inventory refresh records the transport change without changing capability assignments. Independent source review approved the change and separately ran all six HTTP tests successfully.

This honors request cancellation; it does not roll back a state write already accepted by the server. Durable late tool settlement retains its deliberately independent signal. No new checkpoint execution API is introduced.

Integration: current main is included and all PR commits are signed. Head d570471b5 passed 594 runtime tests, runtime/public types, 183 workflow/scope/review-verification tests, inventory and source boundaries. Current head 420c30f8e552adfcc772c88f0ce6bc73ae3bfa86 adds only main's website comment corrections; the fresh 594-test runtime run and website font-variable target pass. Required CI run 35913390368 must pass on this exact head before merge. The diff remains limited to the transport, six HTTP regressions, inventory fingerprint and generated API parameter name.

@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
threadplane Ready Ready Preview Sep 23, 2026 8:06pm UTC

Request Review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval: this PR received an intelligent (AI) code review. See the review comments on this PR.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

Forward the existing AbortSignal to LangGraph state writes and cover cancellation through normal and protected transports with real HTTP regressions. Include the generated API documentation and parity inventory update.
@blove
blove force-pushed the codex/state-write-cancellation branch from 54c3472 to f91f5c8 Compare September 23, 2026 19:21
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@blove
blove merged commit 0dc481b into main Sep 23, 2026
76 of 77 checks passed

This branch was successfully deployed

1 active deployment
Preview – threadplane — 420c30f8 Deployed Sep 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant