Skip to content

Prove application-owned thread session lifetime - #1131

Merged
blove merged 5 commits into
mainfrom
codex/thread-session-lifetime
Sep 23, 2026
Merged

blove merged 5 commits into
mainfrom
codex/thread-session-lifetime

Conversation

@blove

@blove blove commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Applications need to change conversations without mixing old execution, history or tool settlement into the new thread. This PR demonstrates selecting application-owned, fixed-thread sessions in both native bindings: selection starts empty, history is explicitly loaded, and the example disposes the outgoing session. Separate binding tests demonstrate retaining it instead.

The new /?threads installed-consumer view covers same-thread selection, returning to a fresh session, switching during a running stream or pending history request, and permanent owner disposal. React observes the selected session; Angular recreates a keyed observation scope. Runtime regressions cover late history, concurrent sessions, thread-scoped tool claims and late durable settlement under a retired thread. No production runtime, core or binding API changes are needed.

Validation:

  • 578 runtime tests, strict runtime types and lint (zero errors; 68 existing warnings).
  • Native/core/content tests, types, lint and fresh builds; 442 infrastructure tests.
  • Both packed consumers and the review CLI pass all 21 Playwright scenarios per framework.
  • Chrome MCP and the Codex in-app browser each pass the 13-action thread workflow in React and Angular: exactly four history POSTs and two run POSTs, outgoing stream/history aborts, no console warnings/errors. Mobile layouts fit at 390px.
  • Source/built boundaries and inventory checks pass. The four unrelated webhook files merged in Recover Resend suppression and bounce webhooks #1128 changed no runtime bytes; their 68 affected tests also pass.

Source fingerprints, actual installed package hashes, command logs and browser proof are recorded in fixtures/react-parity/runtime/evidence.json. Contributor guidance explains the lifetime policy and manual review sequence.

Scope and review: thread creation/list CRUD, actual URL routing integration, checkpoint execution, public backend cutover and native component parity remain later work. Disposal cancels local ownership, not remote execution or side effects. Parent spec/source/lifecycle/type/evidence audits completed; independent agent capacity is exhausted in this thread. A hosted review job is counted as review only if it produces substantive output.

Main integration includes #1129's website split (20 workspace checks passed) and the later #1130/#1135 Resend fixes (focused growth webhook Nx checks passed). The recorded 813-file runtime fingerprint remains unchanged on current head 0a5bb0979.

Hosted review jobs, including workflow 35807392284 on 0a5bb0979, returned is_error: true despite successful job conclusions. They produced no substantive review and are not counted as independent review evidence.

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
threadplane Ready Ready Preview Sep 23, 2026 2:38am UTC

Request Review

@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval: this PR received an intelligent (AI) code review. See the review comments on this PR.

@github-actions

github-actions Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@github-actions

github-actions Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@github-actions

github-actions Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@github-actions

github-actions Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@blove
blove merged commit 5beb916 into main Sep 23, 2026
77 checks passed

This branch was successfully deployed

1 active deployment
Preview – threadplane 1a47dfb0 Deployed Sep 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant