Skip to content

docs(l1-latency): end the hookless-fork sampling window at the latency report (LAB-12414) - #708

Open
27Bslash6 wants to merge 1 commit into
mainfrom
lab-12414-sampling-window-wording
Open

27Bslash6 wants to merge 1 commit into
mainfrom
lab-12414-sampling-window-wording

Conversation

@27Bslash6

Copy link
Copy Markdown
Contributor

The hookless-fork sampling window now ends where the code ends it: at the child's first construction or use of a latency report. Building or using a backend with no report (telemetry off, or a clock that does not qualify) does not end it, and neither does a health check, which never takes a report. This restates API-81's boundary in spec/saas-api.md on protocol main.

Changed: the sampling_rng comment in src/cachekit/decorators/l1_latency.py, the "L1 hit latency" paragraph in docs/backends/cachekitio.md, and the decorators/l1_latency.py row of the thread-safety table in docs/free-threading.md. Comment and docs only; no behaviour change.

Closes LAB-12414

@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 61db1f6 and d6ef520.

Files selected for processing: 3
  • docs/backends/cachekitio.md
  • docs/free-threading.md
  • src/cachekit/decorators/l1_latency.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kodus-27b

kodus-27b Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the `@kody start-review` command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Providing Context (Files & MCPs)

Add these hints in your PR description (or a comment) to unlock deeper checks:

  • Ticket / Acceptance Criteria: `Refs: ABC-123` (Linear/Jira/Asana/ClickUp/Trello) or a direct ticket link.
  • Bugfix Validation: a Sentry/Datadog/Bugsnag event link (or paste the stack trace/error message).
  • Endpoint Risk: mention the route (e.g., `POST /api/payments`) or controller/action name.
  • Attach a repo file as context: use an explicit marker like `@file:docs/guide.mdx#L10-L50` (replace with your real path).
  • API Contract Docs: include `@file:openapi.yaml` or `@file:swagger.json` when changing routes/schemas.
  • Definition of Done / Standards: include `@file:DOD.md` or `@file:CONTRIBUTING.md` if your repo has them.
  • Design System Source of Truth: include `@file:ui/index.ts` (replace with your DS entrypoint path).
  • Feature Flags: include the flag key/name and `@file:flags.ts` / `@file:config.json` (and optionally the PostHog flag name).
  • Edge/CDN Rules: link the Cloudflare rule/zone or describe the intended redirect/header behavior.
  • Attach an MCP tool output: use `@mcp<provider|tool>` (replace with an installed MCP provider + tool, e.g., `@mcp<sentry|events.search>`).
Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ✅

Access your configuration settings here.

@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Instruction budget: PASS

Head d6ef5205e433ed2a5e8deebecb984f8a26b0a4c8 measured against base 61db1f62570cd196db5d67568c61be423a8d4bd0 on the same runner, on cpython-3.12-x86_64 (3.12.3). Workflow run

Verdict Path Head Ir/op Base Ir/op Delta
ok byte_storage_store_40b 2,792 2,792 +0.00%
ok byte_storage_store_64k 724,805 724,806 -0.00%
ok file_set 86,827 86,827 +0.00%
ok l1_hit 2,889 2,889 +0.00%
ok l1_hit_backed 89,462 89,417 +0.05%
ok l1_hit_backed_auto 102,412 102,411 +0.00%
ok l2_hit 186,642 186,680 -0.02%
ok l2_hit_async_metrics 186,685 186,535 +0.08%
ok minimal_l1_hit 2,881 2,881 +0.00%
ok miss 242,506 242,530 -0.01%
ok object_cache_put_full 198,766 198,769 -0.00%
ok secure_l1_hit 139,130 139,131 -0.00%
ok serializer_arrow 2,211,407 2,211,346 +0.00%
ok serializer_auto 71,003 71,006 -0.00%
ok serializer_default 52,487 52,488 -0.00%
ok serializer_default_records 1,061,043 1,061,044 -0.00%
ok serializer_encrypted 97,319 97,320 -0.00%
ok serializer_orjson 24,413 24,415 -0.01%

A path fails at +1% or more against the base (+2% for serializer_orjson). This check is not required: a deliberate cost increase is accepted at merge. Method: docs/performance.md, Instruction budgets.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant