[Test] Fix CrashReportTest to support non-product builds - #164
Open
sendaoYan wants to merge 1 commit into
Open
Conversation
…g) builds The hs_err JRE version line format differs between product and non-product builds. For product builds the line contains "(build <version>)", while for fastdebug/slowdebug builds it contains "(fastdebug build <version>)" or "(slowdebug build <version>)". The test regex previously only matched the product build format, causing the test to fail on fastdebug/slowdebug builds. Fix the regex to optionally match the debug level prefix before "build": \(build -> \((?:fastdebug |slowdebug )?build Issue: bytedance#163
Collaborator
Author
|
github action job报错，看起来像是环境问题 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hs_err JRE version line format differs between product and non-product builds. For product builds the line contains "(build )", while for fastdebug/slowdebug builds it contains "(fastdebug build )" or "(slowdebug build )". The test regex previously only matched the product build format, causing the test to fail on fastdebug/slowdebug builds.
Fix the regex to optionally match the debug level prefix before "build":
(build -> ((?:fastdebug |slowdebug )?build
Issue: #163