Correct 2 s390x Vector Evaluate bugs#13019
Open
theotherjimmy wants to merge 2 commits intobytecodealliance:mainfrom
Open
Correct 2 s390x Vector Evaluate bugs#13019theotherjimmy wants to merge 2 commits intobytecodealliance:mainfrom
theotherjimmy wants to merge 2 commits intobytecodealliance:mainfrom
Conversation
alexcrichton
requested review from
uweigand
and removed request for
alexcrichton
Contributor
Author
|
My bad about the test failures. I'll fix them. |
The vec eval bug was created by generating all of the masks with a script, and then updating the masks in place without reordering the arguments to these 2 cases. Reported-by: Shun Kashiwa <shunthedev@gmail.com> @shumbo
This bug was inruduced by mistakenly swapping the divisor and dividend in the overflow check included in sdiv.i128. Reported-by: Shun Kashiwa <shunthedev@gmail.com> @shumbo
theotherjimmy
force-pushed
the
s390x-veval-bug
branch
from
56b252a to
222853a
Compare
Contributor
Author
|
Test failures were related to having forgotten to bless the new precise compile output for these two bugs. |
github-actions
bot
added
the
cranelift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs:
a and (not b) and cI have added runtests for both of these bugs in their respective commits.
Thanks for reporting these bugs @shumbo !