feat(wkg,core,client): intial wkg workspace approach#231
Open
mkatychev wants to merge 12 commits into
Open
Conversation
mkatychev
force-pushed
the
mkatychev/feat/wkg-workspaces
branch
from
780ef2a to
16c8e3a
Compare
mkatychev
added a commit
that referenced
this pull request
Jul 11, 2026
Split changes from #231 in preparation for `WorkspaceConfig`/`WorkspaceRootConfig` additions. * added `PackageRef` to `Error::VersionAlreadyExists`: https://github.com/bytecodealliance/wasm-pkg-tools/blob/068a2b321d5680db9829323eac1741839b90c39a/crates/wasm-pkg-common/src/lib.rs#L58-L59 * introduce `pub const WIT_DEPS_DIR`: https://github.com/bytecodealliance/wasm-pkg-tools/blob/068a2b321d5680db9829323eac1741839b90c39a/crates/wasm-pkg-core/src/wit.rs#L31-L32 * add `PublishVerifier` to reuse logic between current multi package publishing eventual workspace fetching found in #231: https://github.com/bytecodealliance/wasm-pkg-tools/blob/790b44cbea5cd24a57f448ca86a624dcc52eb426/crates/wkg/src/overlay.rs#L21-L31
mkatychev
commented
Jul 11, 2026
| /// A `false` return does NOT mean the package is definitely not a member - | ||
| /// it could still be a member via path dependencies. Callers should fallback | ||
| /// to full workspace loading when this returns `false`. | ||
| // FIXME: implement cargo WorkspaceRootConfig::{member_paths, expand_member_path} |
Member
Author
There was a problem hiding this comment.
Current workspace members are eagerly evaluated to this functions more like is_member for the moment, I can implement the member_paths and expand_member_path functionality here or in a follow-up. The distinction should not matter until WorkspaceConfig::Member is implemented.
mkatychev
force-pushed
the
mkatychev/feat/wkg-workspaces
branch
from
94bfd28 to
1367cc3
Compare
…ultiple_transitive_local_packages`
mkatychev
force-pushed
the
mkatychev/feat/wkg-workspaces
branch
from
cf99224 to
b562b52
Compare
mkatychev
force-pushed
the
mkatychev/feat/wkg-workspaces
branch
from
8f168c9 to
574197c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR adds initial workspace support for
wkg fetchandwkg publishIntroduced
WorkspaceConfigto manage workspace configurations in manifests:wasm-pkg-tools/crates/wasm-pkg-core/src/manifest/workspace.rs
Lines 11 to 20 in 0616061
WorkspaceRootConfigadded as a virtual-manifest stand-in:wasm-pkg-tools/crates/wasm-pkg-core/src/manifest/workspace.rs
Lines 48 to 53 in 0616061