fix(ci): add riscv64 sources list explicitly for cross-rs#227
Merged
vados-cosmonic merged 1 commit intoJul 10, 2026
Merged
Conversation
This commit adds a hack to fix riscv64 cross builds which were missing libssl-dev packages on Ubuntu. While the package *is* present, attempting to install via the normal route seems to fail, and the existing package is not properly resolved. By more explicitly adding riscv64 noble as a source, the libssl-dev:riscv64 package is properly picked up and used during the build.
mkatychev
reviewed
Jul 10, 2026
mkatychev
left a comment
Member
There was a problem hiding this comment.
LGTM,
maybe for now we can add a trigger that (for now) runs on PRs that modify the cross compilation:
https://github.com/bytecodealliance/wasm-pkg-tools/blob/main/.github/workflows/publish-binaries.yml#L3-L7
on:
pull_request:
branches: ["**"]
paths:
- "Cross.toml"
- ".github/workflows/publish-binaries.yml"and we can detect if we're in a PR by excluding main and tagged stuff:
if: ${{ github.ref != 'refs/heads/main' && !startsWith( github.ref, 'refs/tags/v' ) }}
run: do my tests --here
mkatychev
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a hack to fix riscv64 cross builds which were missing libssl-dev packages on Ubuntu. While the package is present, attempting to install via the normal route seems to fail, and the existing package is not properly resolved.
By more explicitly adding riscv64 noble as a source, the libssl-dev:riscv64 package is properly picked up and used during the build.
This fix is admittedly fragile, but we are depending on the
edgetag for cross-rs, which is inherently unstable (and likely caused this issue in the first place). Unfortunately the last non-edgerelease is from years ago.Alternatively a solution I'm open to is pinning the edge release, but this may also change out from under us given that the intermediate/past shas do not seem to be retained upstream.