Skip to content

fix(ci): add riscv64 sources list explicitly for cross-rs#227

Merged
vados-cosmonic merged 1 commit into
bytecodealliance:mainfrom
vados-cosmonic:fix(ci)=riscv-build
Jul 10, 2026
Merged

fix(ci): add riscv64 sources list explicitly for cross-rs#227
vados-cosmonic merged 1 commit into
bytecodealliance:mainfrom
vados-cosmonic:fix(ci)=riscv-build

Conversation

@vados-cosmonic

Copy link
Copy Markdown
Contributor

This commit adds a hack to fix riscv64 cross builds which were missing libssl-dev packages on Ubuntu. While the package is present, attempting to install via the normal route seems to fail, and the existing package is not properly resolved.

By more explicitly adding riscv64 noble as a source, the libssl-dev:riscv64 package is properly picked up and used during the build.

This fix is admittedly fragile, but we are depending on the edge tag for cross-rs, which is inherently unstable (and likely caused this issue in the first place). Unfortunately the last non-edge release is from years ago.

Alternatively a solution I'm open to is pinning the edge release, but this may also change out from under us given that the intermediate/past shas do not seem to be retained upstream.

This commit adds a hack to fix riscv64 cross builds which were missing
libssl-dev packages on Ubuntu. While the package *is* present,
attempting to install via the normal route seems to fail, and the
existing package is not properly resolved.

By more explicitly adding riscv64 noble as a source, the
libssl-dev:riscv64 package is properly picked up and used during the build.

@mkatychev mkatychev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
maybe for now we can add a trigger that (for now) runs on PRs that modify the cross compilation:
https://github.com/bytecodealliance/wasm-pkg-tools/blob/main/.github/workflows/publish-binaries.yml#L3-L7

on:
  pull_request:
    branches: ["**"]
    paths: 
    - "Cross.toml"
    - ".github/workflows/publish-binaries.yml"

and we can detect if we're in a PR by excluding main and tagged stuff:

if: ${{ github.ref != 'refs/heads/main' && !startsWith( github.ref, 'refs/tags/v' ) }}
run: do my tests --here

@vados-cosmonic vados-cosmonic merged commit 123c8c8 into bytecodealliance:main Jul 10, 2026
3 checks passed
@vados-cosmonic vados-cosmonic deleted the fix(ci)=riscv-build branch July 10, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants