Prefer OptionalPassInfoMixin#5010
Open
boomanaiden154 wants to merge 1 commit into
Open
Conversation
LLVM 23 prefers {Optional,Required}PassInfoMixin rather than
PassInfoMixin and explicitly (or not) setting isRequired. In LLVM 24,
PassInfoMixin will be moved to a detail namespace and thus will cause a
compilation failure.
boomanaiden154
requested review from
TianlongLiang,
lum1n0us,
no1wudi and
yamt
as code owners
July 25, 2026 12:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLVM 23 prefers {Optional,Required}PassInfoMixin rather than PassInfoMixin and explicitly (or not) setting isRequired. In LLVM 24, PassInfoMixin will be moved to a detail namespace and thus will cause a compilation failure.