Skip to content

fix(p2-shim): correct TCP socket state transitions #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vados-cosmonic merged 1 commit into from
Aug 24, 2026
+10 −9
Merged

fix(p2-shim): correct TCP socket state transitions #1975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions packages/preview2-shim/src/io/worker-socket-tcp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import {
pollStateReady,
verifyPollsDroppedForDrop,
} from "./worker-thread.js";
import process from "node:process";
import {
convertSocketError,
ipSocketAddress,
Expand All @@ -31,8 +30,6 @@ import {
import { Server, Socket as TcpSocket } from "node:net";
import { IpSocketAddress } from "../../types/interfaces/wasi-sockets-network.js";

const win = process.platform === "win32";

interface PendingAccept {
tcpSocket: TcpSocket | null;
err: Error | null;
Expand Down Expand Up @@ -89,7 +86,15 @@ export function socketTcpFinish(id: number, fromState, toState) {
futureDispose(socket.future, false);
socket.future = null;
if (tag === "err") {
socket.state = SOCKET_STATE_CLOSED;
// A failed bind does not consume the socket. In particular, callers may
// retry after `address-in-use` with another address or port.
if (fromState === SOCKET_STATE_BIND) {
socket.server = null;
socket.localAddress = null;
socket.state = SOCKET_STATE_INIT;
} else {
socket.state = SOCKET_STATE_CLOSED;
}
throw val;
} else {
socket.state = toState;
Expand Down Expand Up @@ -340,11 +345,7 @@ export function socketTcpShutdown(id: number, _shutdownType) {
if (socket.state !== SOCKET_STATE_CONNECTION) {
throw "invalid-state";
}
if (win && socket.tcpSocket?.destroySoon) {
socket.tcpSocket.destroySoon();
} else {
socket.tcpSocket?.destroy();
}
socket.tcpSocket?.destroy();
}

export function socketTcpSetKeepAlive(id: number, { keepAlive, keepAliveIdleTime }) {
Expand Down
Loading