Add mdbook-tabs dependency#359
Closed
MA3CIN wants to merge 1 commit into
Closed
Conversation
Signed-off-by: MA3CIN <marcinziolkowskicloud@gmail.com>
Collaborator
Contributor
Author
|
@vados-cosmonic Ahhh, I see, unfortunate |
Collaborator
|
No worries! It's definitely a problem and it's taking us an uncharacteristically long time to merge -- this will be fixed soon. Thanks for taking the time to fix it an send a PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the recent WASIP3 release, the https://component-model.bytecodealliance.org/running-components/wasmtime.html page was changed to include tabs for Wasip2/Wasip3. But the dependency (mdbook-tabs) was not added to neither the install instruction for contributors, nor to the github workflows. This PR adds it to both.
Without this PR:
Local version, with the changes from this PR:
Version 0.1.13 of mdbook-tabs is the newest version not to clash with mdbook.0.4.21. Newer ones would require an update to mdbook itself.