test: build booking fixtures with frappe_factory_bot factories

[harshtandiya]

What changed

Fixture setup in the backend suite is duplicated everywhere — test_buzz_coupon_code.py
has 74 raw frappe.get_doc({...}) call sites, test_event_booking.py 68 — and an informal
factory layer has already grown by accident. test_buzz_team.py is imported by ten other
test files for create_user / create_owned_team, and payload_for is a per-doctype
default_attributes table in all but name.

This adopts frappe_factory_bot properly, on one module first. buzz/api/booking/test_booking.py
is the tracer bullet: its setUpClass builds the whole association chain, so converting it
exercises every factory added here. −118/+31 lines in that file.

• buzz/tests/factories/ — User, Buzz Team, Event Category, Event Host, Buzz Event,
  Event Ticket Type, Ticket Add-on.
• CI installs the app via bench get-app in setup-bench. No install-app (it ships no
  DocTypes, only a Python import), and deliberately not in required_apps — production
  Buzz should not carry a test library.
• A writing-tests skill documenting the conventions and the traps below.

Three Frappe-level traps, all found the hard way, all now in the skill:

• A team inserted plainly as Administrator becomes Administrator's default team for every
  later run on that site — create_default_team_for takes the first enabled Owner
  membership, and process_booking commits, so the row survives rollback. setup_test_records()
  then fails with Venue Test Venue belongs to another team. Hence BuzzTeamFactory.create_owned_by().
• User.throttle_user_creation throws past 60 new users an hour. Test users are not rolled
  back, so minting a fresh one per fixture trips it after a couple of runs. Hence
  UserFactory.create_once() for fixed identities.
• Faker's unique only dedupes within a process. Prompt-autonamed rows are the primary key
  and outlive the run, so Event Category and Event Host suffix with frappe.generate_hash.

Not changed: frappe_factory_bot itself needed nothing — the flags passthrough already
carries both owner_user and ignore_permissions. Event Booking, Offline Payment Method and
Buzz Coupon Code get no factory yet; nothing here would exercise them, so they land with the
batch that does. The old helpers in test_buzz_team.py / test_forms.py stay — twelve files
still import them, and they retire as each module converts.

Testing

bench --site testbuzz.localhost run-tests --app buzz — 670 tests, 0 failures, green on
repeated back-to-back runs (the cross-run collisions above only surface on the second and
third run). Two consecutive full runs created 3 users total, so CI's fresh site is nowhere
near the throttle.

🤖 Generated with Claude Code

https://claude.ai/code/session_016dbs2RcPoTwFTM2JTE386q

[greptile-apps]

Greptile Summary

This PR introduces reusable frappe_factory_bot fixtures and converts the booking API tests to use them.

• Adds factories for users, teams, events, categories, hosts, ticket types, and add-ons.
• Pins the test-only factory dependency to a reviewed commit during bench setup.
• Documents fixture conventions and safeguards for repeatable Frappe tests.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
.github/actions/setup-bench/action.yml	The previously mutable test dependency is now cloned and checked out at an immutable commit before bench installation.
buzz/api/booking/test_booking.py	Booking test fixture setup is consolidated onto the new factories while preserving the tested booking and permission scenarios.
buzz/tests/factories/buzz_event_factory.py	Adds a published online-event factory that creates or reuses the required team, category, and host associations.
buzz/tests/factories/buzz_team_factory.py	Adds team fixtures with explicit reusable ownership to avoid persistent Administrator-owned test teams.
buzz/tests/factories/user_factory.py	Adds reusable fixed-identity users to avoid repeated creation and Frappe throttling.
buzz/tests/factories/event_category_factory.py	Adds collision-resistant prompt-named category fixtures.
buzz/tests/factories/event_host_factory.py	Adds collision-resistant host fixtures associated with an appropriate team.
buzz/tests/factories/event_ticket_type_factory.py	Adds free and paid ticket-type fixtures with optional event reuse.
buzz/tests/factories/ticket_add_on_factory.py	Adds free and paid add-on fixtures with optional event reuse.

_{Reviews (3): Last reviewed commit: "ci: pin frappe_factory_bot to a reviewed..." | Re-trigger Greptile}