Support secure SSH access for Linux jobs - #955
Open
jamiemonserrate wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
I didn't find a concrete issue in this pass. This changes SSH server authentication and host-key verification, so I'm leaving a comment rather than approving under the L1 ceiling.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 18968, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
About buildsworth
Model: gpt-5.6-sol with xhigh thinking.
How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.
Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. Unless repository policy already allows L2 approval, grant it by mentioning @buildsworth-bk (see approval ceiling and L2 approval grant):
- L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
- L2 — Standard risk (new UI, additive API fields, refactors). Approved only when repository policy or a verified grant allows it; otherwise comment-only.
- L3 — High risk (auth, migrations, payments, secrets, perf-critical paths). Human review always required.
buildkate
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Linux hosted-job support to
bk job sshusing Namespace's TCP container endpoint with SSH host-key verification.The CLI consumes the
transportandssh.host_keysfields from the existing SSH session endpoint. Raw TCP sessions require at least one valid host key and fail closed if verification cannot be performed.Existing macOS jobs continue using authenticated Namespace WSS ingress. If host keys are supplied for ingress sessions, the CLI verifies those too.
Context: A-1682
Changes
tcpandnamespace_ingressSSH transports explicitly.Deployment
Deploy the corresponding Buildkite API changes before relying on Linux SSH sessions. The CLI will fail closed if a TCP response does not include valid host keys.
Rollback
Reverting this change restores the previous WSS-only behavior. Linux TCP sessions will be rejected, while existing macOS SSH sessions remain supported.
Testing
go test ./...)golangci-lintpassesgovulncheck ./...reports no called vulnerabilitiesDisclosures / Credits
Implemented with Codex. Codex gathered the linked Linear, Slack, Notion, Namespace API, and prior PR context; implemented the CLI transport and host-key verification changes; and added and ran the automated coverage. Jamie reviewed the plan, API alignment, and resulting implementation.