IVS-673: advance progress only after a task completes#307
Open
Ghesselink wants to merge 3 commits into
Open
Conversation
Prevents reporting 100% while instance completion still runs; atomic Least(F(progress)+inc, 100) update avoids the parallel-stage race.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A file briefly shows "100% complete" while Instance Completion is still running.
Each subtask bumped
request.progressat its start, and the increments sum to exactly100 — so the final task tipped the bar to 100 before doing its work.
Fix
Advance
request.progressonly after a task's execution + processing finish. The updateis atomic —
Least(F("progress") + increment, 100)— to avoid the parallel-stageread-modify-write race. Failed tasks return early and don't advance progress.
Tests
tests_progress_update.py(3): progress advances only after work completes (fails on thepre-fix code with
10 != 0), clamps at 100, and a failed task doesn't advance.