Support for level parameter in constructor#249
Closed
ForroKulcs wants to merge 1 commit into
Closed
Conversation
Member
|
Hi @ForroKulcs . Thanks for the PR, this sounds like a good idea. We will review in due course. |
johnkiely1
added
backlog
Contributor
|
Thank you for your contribution. This is included in 416(#416) |
|
This is included in 416(#416) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
logging.Handler supports level parameter. This change is to enable forwarding this value.
Design
level is introduced as first parameter as it is also the first parameter of logging.Handler
Changeset
constructor declaration was changed
Testing
manual local test was used