feat: Add defaultCategory to Phase 2 bulk-review rules#244
Open
rajathmr2000 wants to merge 17 commits into
Open
feat: Add defaultCategory to Phase 2 bulk-review rules#244rajathmr2000 wants to merge 17 commits into
rajathmr2000 wants to merge 17 commits into
Conversation
Wire seven axe-core rules to their Phase 2 bulk-review categories via metadata.defaultCategory (reference data only; no rule logic change): aria-hidden-focus -> aria-hidden aria-valid-attr-value -> aria-attributes bypass -> bypass-blocks css-orientation-lock -> orientation duplicate-id-aria -> duplicate-ids identical-links-same-purpose -> link-consistency video-caption -> media-captions Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add reviewPayload.visualHelperData emits for aria-valid-attr-value, aria-hidden-focus, identical-links-same-purpose and duplicate-id-aria (dedicated evaluate/after), plus their unit specs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collapse the dedicated duplicate-id-aria evaluate/after back into the shared duplicate-id-evaluate/duplicate-id-after, gated by a `reviewPayload` check option. The aria check enables the bulk-review payload via that option; the static/active checks keep their original string `data` and are behaviourally unchanged. Adds tests for both data shapes and verdict parity. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rajathmr2000
commented
Jun 29, 2026
rajathmr2000
left a comment
rajathmr2000
left a comment
Collaborator
Author
There was a problem hiding this comment.
Claude Code Review (automated) — 4 inline finding(s). Full report in the PR comment below. Verdict: Passed.
rajathmr2000
changed the title
Wire metadata.defaultCategory for the prioritized rules (aria-valid-attr-value, video-caption, bypass, css-orientation-lock) and emit reviewPayload.visualHelperData for aria-valid-attr-value. Excludes aria-hidden-focus / identical-links-same-purpose / duplicate-id-aria (deferred). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rajathmr2000
commented
Jun 29, 2026
rajathmr2000
left a comment
rajathmr2000
left a comment
Collaborator
Author
There was a problem hiding this comment.
Claude Code Review (automated) — 4 inline finding(s). Full report in the PR comment below. Verdict: Failed - see PR comment.
Update the 8 needs-review deepEqual expectations in valid-attr-value.js to include the reviewPayload the check now emits on the needs-review path, and add the // a11y-rule-aria-valid-attr-value tag on the emit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Normalize the // a11y-rule comment indentation (tab -> spaces) so fmt:check (prettier --check) passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rajathmr2000
force-pushed
the
feat/AXE-3625-phase-2-bulk-review
branch
from
June 29, 2026 10:52
5d1b443 to
32c3c05
Compare
rajathmr2000
changed the base branch from
main
to
feat/AXE-3625-bulk-review-priority
July 9, 2026 10:37
rajathmr2000
changed the base branch from
feat/AXE-3625-bulk-review-priority
to
main
July 9, 2026 10:37
…e PR # Conflicts: # lib/checks/aria/aria-valid-attr-value-evaluate.js
chikara1608
requested changes
Jul 17, 2026
| : false; | ||
|
|
||
| // a11y-rule-aria-hidden-focus: emit focusable descendants for bulk review; additive, guarded. | ||
| try { |
Collaborator
There was a problem hiding this comment.
same logic; can be abstracted and used in both files?
| duplicateId: id, | ||
| elements: matchingNodes | ||
| .filter(Boolean) | ||
| .map(foundNode => new axe.utils.DqElement(foundNode).selector) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.