sio/csupio: don't close underlying io.Reader - #7235
Open
nwt wants to merge 1 commit into
Open
Conversation
If the io.Reader argument to NewReader implements io.Closer, then Reader.ConcurrentPull will close it at EOS. This can cause a panic if methods on vector.TypeValue instances are called that use TypeValue.loader because they rely on the reader. Fix that by removing the code that closes the underlying reader. This aligns csupio.Reader behavior with that of the other sio.Reader implementations, none of which close their underlying reader. Closing them in a timely fashion rather than relying on the garbage collector to close them is future work.
mattnibs
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the io.Reader argument to NewReader implements io.Closer, then Reader.ConcurrentPull will close it at EOS. This can cause a panic if methods on vector.TypeValue instances are called that use TypeValue.loader because they rely on the reader. Fix that by removing the code that closes the underlying reader.
This aligns csupio.Reader behavior with that of the other sio.Reader implementations, none of which close their underlying reader. Closing them in a timely fashion rather than relying on the garbage collector to close them is future work.