jsonio.valReader: use io.ReadFull to read buffer - #7194
Merged
Conversation
nwt
approved these changes
Aug 14, 2026
This commit changes the behavior of the fill() method in valReader to use use io.ReadFull to fill the buffer. The code was mistakenly assuming calls to Read would fill the passed buffer unless EOF was reached. This commit also resolves a panic that occurs when no values are read from a batch by returning nil if the vector.BytesTable is empty. Closes #7163
mattnibs
force-pushed
the
jsonio-valreader-full
branch
from
August 14, 2026 21:11
b6422bf to
112762b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the behavior of the fill() method in valReader to use use io.ReadFull to fill the buffer. The code was mistakenly assuming calls to Read would fill the passed buffer unless EOF was reached.
This commit also resolves a panic that occurs when no values are read from a batch by returning nil if the vector.BytesTable is empty.
Closes #7163