Skip to content

Add Korean UI localization#500

Draft
hjoungjoo wants to merge 1 commit into
brickbots:mainfrom
hjoungjoo:pr/korean-localization
Draft

Add Korean UI localization#500
hjoungjoo wants to merge 1 commit into
brickbots:mainfrom
hjoungjoo:pr/korean-localization

Conversation

@hjoungjoo

Copy link
Copy Markdown

Summary

This draft PR is a small localization split from my Raspberry Pi 4/CM5 compatibility branch.

It adds Korean as a selectable UI language:

  • add Korean gettext catalog files
  • add Korean to the language menu and extraction markers
  • allow --lang ko for development/testing
  • use the existing Sarasa CJK font for Korean, like Chinese
  • restart PiFinder after switching to Korean so the CJK font is reloaded

Out of scope for this PR:

  • hardware compatibility changes
  • install script changes
  • Bluetooth keyboard work
  • focus/gain changes
  • MF_PiFinder-specific documentation

Tested

  • python3 -m compileall -q PiFinder
  • python3 -m ruff check PiFinder tests
  • python3 -c "import gettext; tr=gettext.translation('messages','locale',languages=['ko']); print(tr.gettext('Start')); print(tr.gettext('Korean'))"
  • python3 -m pytest tests/test_main.py tests/test_menu_struct.py -q

@jscheidtmann jscheidtmann left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants