fix: preserve query string in config.options when parsing connection URL#3653
Closed
mujib77 wants to merge 3 commits intobrianc:masterfrom
Closed
fix: preserve query string in config.options when parsing connection URL#3653mujib77 wants to merge 3 commits intobrianc:masterfrom
mujib77 wants to merge 3 commits intobrianc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When parsing a PostgreSQL connection URL with query parameters
(e.g.
?schema=public&ssl=true), the parser spreads each paramdirectly onto the config object but never preserves the raw query
string in
config.options.This breaks code that expects
config.optionsto contain theoriginal query string — for example, when reconstructing connection
URLs or implementing SSH tunneling.
Fixes #3418
Solution
After parsing search params, save the raw query string to
config.optionsif it exists:Test
Manually verified that parsing a URL with query params now
correctly populates
config.options.